Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse: Detect tables in a SELECT INTO clause as DDL tables #281

Merged
merged 2 commits into from
Mar 25, 2023
Merged

Parse: Detect tables in a SELECT INTO clause as DDL tables #281

merged 2 commits into from
Mar 25, 2023

Conversation

lfittl
Copy link
Member

@lfittl lfittl commented Mar 24, 2023

Fixes #280

@lfittl lfittl mentioned this pull request Mar 24, 2023
Closed
@lfittl lfittl requested a review from a team March 24, 2023 03:54
keiko713
keiko713 approved these changes Mar 24, 2023
View reviewed changes
Copy link

@keiko713 keiko713 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤳

olleolleolle
olleolleolle reviewed Mar 24, 2023
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool feature!

spec/lib/parse_spec.rb Outdated Show resolved Hide resolved
@lfittl @olleolleolle
Update spec/lib/parse_spec.rb
cd4528a 
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
@lfittl lfittl merged commit 848c9b1 into main Mar 25, 2023
@lfittl lfittl deleted the parse-select-into branch March 25, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle left review comments

@keiko713 keiko713 keiko713 approved these changes

@seanlinsley seanlinsley seanlinsley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Select Into) doesn't return DDL tables
4 participants
@lfittl @olleolleolle @seanlinsley @keiko713