Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote rangevars to support special from clauses #43

Merged
merged 1 commit into from
Dec 15, 2015
Merged

Quote rangevars to support special from clauses #43

merged 1 commit into from
Dec 15, 2015

Conversation

avinoamr
Copy link
Contributor

Similar to #40 . Currently, deparsing special/unsupported from clauses results in incorrect SQL code:

select * from "hello-world"

will deparse into

select * from hello-world

Where the dash is unsupported.

Fixed by quoting all rangevars.

@lfittl
Copy link
Member

lfittl commented Dec 15, 2015

Looks good - thanks for working through these!

lfittl added a commit that referenced this pull request Dec 15, 2015
Quote rangevars to support special from clauses
@lfittl lfittl merged commit e972cb2 into pganalyze:master Dec 15, 2015
@avinoamr
Copy link
Contributor Author

@lfittl Thanks for merging. Did you publish the changes yet?

@lfittl
Copy link
Member

lfittl commented Dec 16, 2015

@avinoamr I didn't release a new gem version yet - I'll do that tonight 👍

@avinoamr
Copy link
Contributor Author

Thanks :)

@avinoamr
Copy link
Contributor Author

@lfittl Is it done? I didn't see a new tag.

@lfittl
Copy link
Member

lfittl commented Dec 20, 2015

@avinoamr Apologies, last week was busier than expected - I've released 0.7.2 now :)

@avinoamr
Copy link
Contributor Author

Thanks @lfittl :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants