Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commonly used function uses #50

Merged
merged 1 commit into from
May 31, 2016
Merged

Add commonly used function uses #50

merged 1 commit into from
May 31, 2016

Conversation

Winslett
Copy link
Contributor

@Winslett Winslett commented May 26, 2016 •
edited
Loading

This implementation allows for the following on function initialization:

  • use CREATE OR REPLACE FUNCTION where previously, on CREATE FUNCTION worked
  • remove quotes characters " from around statements for volatility (i.e. IMMUTABLE instead of "IMMUTABLE")
  • accept statements of strictness on functions (i.e. RETURNS NULL ON NULL INPUT)

@Winslett Winslett force-pushed the improve-function-deparsing branch 3 times, most recently from d5737ea to 7bd777f Compare May 26, 2016 20:11
@Winslett
improve function deparsing, with:
4d5480a 
* CREATE OR REPLACE FUCNTION work with deparsing
* remove quotes from functions volatility statement
* deparse properly on functions with strict settings
@Winslett Winslett force-pushed the improve-function-deparsing branch from 7bd777f to 4d5480a Compare May 26, 2016 20:17
@lfittl
Copy link
Member

lfittl commented May 31, 2016

@Winslett Awesome, thanks for working on these, and sorry for the slow reply :)

@lfittl lfittl merged commit b226bdc into pganalyze:master May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Winslett @lfittl