Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ORDER/GROUP BY, HAVING, and booleans in WHERE. #53

Merged
merged 1 commit into from
Jun 20, 2016

Conversation

jcoleman
Copy link
Contributor

No description provided.

@lfittl
Copy link
Member

lfittl commented Jun 20, 2016

@jcoleman Excellent, thanks for thinking of these & the PR.

Ready to merge once the rubocop nitpicks are fixed (see Travis).

@jcoleman jcoleman force-pushed the more-subselect-fixes branch from 5ce0265 to f870ce1 Compare June 20, 2016 20:12
@jcoleman
Copy link
Contributor Author

@lfittl Fixed.

@lfittl lfittl merged commit 036fece into pganalyze:master Jun 20, 2016
@jcoleman
Copy link
Contributor Author

@lfittl If we could get a new release soon that'd be great. We vendor our bundle installs and this bug: rubygems/bundler#4106 is making it so we can't use a git ref in our Gemfile.

@lfittl
Copy link
Member

lfittl commented Jun 20, 2016

@jcoleman Sure thing - I have one more change I want to get in, but I'll try to wrap it up today :)

@jcoleman
Copy link
Contributor Author

@lfittl Just checking back here again to see if you have any updates. Apologies for bugging you again, but we can't merge in our updated code that relies on this until a new version is pushed. Thanks!

@lfittl
Copy link
Member

lfittl commented Jun 22, 2016

@jcoleman Apologies, I got side-tracked with something else. I've released the current master as 0.11.0 to make your life easier :)

Out of curiosity, what are you using pg_query for?

@jcoleman
Copy link
Contributor Author

@lfittl Thanks! We're using it in a custom rspec matcher to verify that certain code only accesses certain tables.

@lfittl
Copy link
Member

lfittl commented Jun 22, 2016

@jcoleman Neat, thats actually a great use case I hadn't thought of :)

Would be happy to add that to the README as an example of what you can do with the parser, in case its open-source.

@jcoleman
Copy link
Contributor Author

It's currently not open source, but I can look into seeing if we might be able to go that route.

@lfittl
Copy link
Member

lfittl commented Jun 22, 2016

@jcoleman Cool, no rush - if you end up releasing it let me know, I could see this being useful to others :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants