Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deparse varchar and numeric casts without arguments. #61

Merged
merged 1 commit into from
Jan 18, 2017

Conversation

jcsjcs
Copy link
Contributor

@jcsjcs jcsjcs commented Jan 18, 2017

When no arguments were supplied when casting to varchar or numeric, deparse was returning ().
e.g.
CAST("name" AS VARCHAR(255)) or "name"::varchar were deparsed as "name"::varchar().

This change returns "name"::varchar in this case and does similar for numeric.

@lfittl lfittl merged commit 1da2ea5 into pganalyze:master Jan 18, 2017
@lfittl
Copy link
Member

lfittl commented Jan 18, 2017

@jcsjcs Good catch, thanks for the contribution!

@jcsjcs
Copy link
Contributor Author

jcsjcs commented Jan 19, 2017

@lfittl A pleasure.

@jcsjcs jcsjcs deleted the cast branch January 19, 2017 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants