Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitespace is swallowed after italic #14

Closed
lyderic opened this issue Dec 30, 2017 · 3 comments
Closed

Whitespace is swallowed after italic #14

lyderic opened this issue Dec 30, 2017 · 3 comments
Assignees
@pgaskin
Labels
bug

Comments

@lyderic
Copy link

lyderic commented Dec 30, 2017 •
edited
Loading

Hi,

kepub files produced with kepubify "swallow" whitespaces after words in italic.

For example, I used it with the French epub file found here:
https://www.ebooksgratuits.com/newsendbook.php?id=2610&format=epub

In the "Préface" (foreword), whenever the italic word Belgica is used, the following word becomes glued right next to it, without whitespace, for example:

...l'exploration de la Belgicaprécède...

instead of:

...l'exploration de la Belgica précède...

I am using version 1.3.5 under Linux. I have also build the current "dev" version from source, it didn't help.

Thanks for this fantastic tool!

Cheers,
L.
@pgaskin
Copy link
Owner

pgaskin commented Jan 3, 2018

Thanks for reporting this issue! I have looked, and can confirm the issue.

I'll fix it sometime this week.

@pgaskin pgaskin added the bug label Jan 3, 2018
@pgaskin pgaskin self-assigned this Jan 3, 2018
@pgaskin pgaskin closed this as completed in a4dea55 Jan 5, 2018
@pgaskin
Copy link
Owner

pgaskin commented Jan 5, 2018 •
edited
Loading

This should be fixed in release v1.3.6 now.

@lyderic
Copy link
Author

lyderic commented Jan 7, 2018 via email

@pgaskin pgaskin mentioned this issue Mar 4, 2018
Closed
pgaskin added a commit that referenced this issue Jan 14, 2020
@pgaskin
Completely rewrote kepub code
1282954 
- Improved robustness
  - More is implemented directly in the HTML parser and renderer (see my fork of x/net/html)
  - Better support for XHTML and HTML5 (rather than using a bunch of workarounds)
  - No more regexps for modifying HTML
- Better smart punctuation
  - More punctuation supported
  - More robust (won't apply to everything unconditionally)
  - Now off by default
- Faster and more efficient (15-30% faster, 50-70% less memory)
  - Less memory allocations and copies due to use of readers and writers rather than storing rhe entire file in memory multiple times
  - Stack-based span adding algorithm (rather than recursive, which has more runtime and memory overhead)
  - Use byte arrays or runes rather than strings where possible
  - Better parallel processing of content files
  - Eliminated memory, goroutine, and file descriptor leaks
- Cleaner and better code
  - Easier to extend
  - More stable API
  - More complete unit tests
- More accurate sentence splitting and segment numbering (checked against 3 recent free books)
  - Better match Kobo's behavior by preserving, but not wrapping (in a koboSpan) TextNodes with only whitespace. Previous versions of kepubify used to collapse it to a single space, which still works, but is less efficient to do and is slightly different than what Kobo does (although it results in the same thing during rendering).
  - Fixed some edge cases where the segment counter could be incorrectly incremented.
  - Also increment paragraph counter for tables (this case was missing before).
  - Don't increment paragraph counter if spans were added (i.e. an empty or only whitespace paragraph element) (this case was missing before).
- Smaller binary size
- Also run tests on Windows

closes #47, fixes #45, fixes #35
better fix for #36, #29, #28, #26, #21, #14, #10, #5, and #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgaskin pgaskin

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lyderic @pgaskin