-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patches for 4.24.15672 #76
Comments
|
|
Resource extraction: ./qrc2zip --output "nickel.15672.qInitResources_resources.zip" --recursive --verbose "nickel" 1 $((0x115dfe8 - 0x0010000)) $((0x0026948 - 0x0010000)) $((0x115db98 - 0x0010000))
./qrc2zip --output "nickel.15672.qInitResources_translations.zip" --recursive --verbose "nickel" 1 $((0x14b8e68 - 0x0010000)) $((0x115e388 - 0x0010000)) $((0x14b8be0 - 0x0010000))
./qrc2zip --output "nickel.15672.qInitResources_styles.zip" --recursive --verbose "nickel" 1 $((0x14d58f0 - 0x0010000)) $((0x14b8f80 - 0x0010000)) $((0x14d3310 - 0x0010000))
./qrc2zip --output "nickel.15672.qInitResources_certificates.zip" --recursive --verbose "nickel" 1 $((0x14fcc48 - 0x0010000)) $((0x14d63a8 - 0x0010000)) $((0x14fbbf8 - 0x0010000)) https://krc.storage.pgaskin.net/nickel.15672.qInitResources_certificates.zip
|
@pgaskin I'm a bit slow seeing this tonight, but better late than never. Looks interesting. Did you produce the resource map we discussed last time? Here's the first few lines from the previous fw as a reminder.
|
@jackiew1, here it is:
|
Patch test results:
Not too much worse than usual. The only ones which will need additional changes to apply are The majority of the work for this release will be for dictutil, as I'll basically need to check everything from the beginning again to ensure I don't miss any changes. @jackiew1, if everything's good with the nickel patches, I hope to release at least the patches tonight (I'll start working on them once I finish skimming the dictionary stuff). |
Thanks for the map. 😄 If patch |
I'm going to start working on the patches now. |
I just finished looking at the TOC indent patches, and I've decided to remove them since the fixes have been integrated into the original firmware. I will add a new nickel patch in case someone dislikes the new indentation width: Change TOC level indentation:
- Enabled: no
- Description: |
Changes the size of indentation for each level in the TOC. This patch
replaces the old "Increase TOC level indentation" patch from firmware
versions before 4.24.15672 (see the note in libnickel.so.1.0.0.yaml).
- FindZlib: "qproperty-indentUnit"
- ReplaceZlibGroup:
Replacements:
# Change the replacement values to your desired width (I've made it half the default width as an example).
- {Find: "qproperty-indentUnit: 30;", Replace: "qproperty-indentUnit: 15;"} # trilogy
- {Find: "qproperty-indentUnit: 38;", Replace: "qproperty-indentUnit: 19;"} # phoenix
- {Find: "qproperty-indentUnit: 58;", Replace: "qproperty-indentUnit: 29;"} # dragon
- {Find: "qproperty-indentUnit: 72;", Replace: "qproperty-indentUnit: 36;"} # storm
- {Find: "qproperty-indentUnit: 76;", Replace: "qproperty-indentUnit: 38;"} # daylight |
I will not be able to update |
@jackiew1, any update on the nickel patch? |
Notable changes: - "Increase TOC level indentation" and "Increase TOC level indentation and fix extra indentation bug" have been removed since the fixes have been integrated into the original firmware. - "Increase page navigation history" has been removed since the code has changed too much. I might consider rewriting this patch later. - "Dictionary text font-family/font-size/line-height" is waiting on @jackiew1.
I think all existing nickel patches should run without error. However, I've been meaning to get around to updating these 2 to make better use of available space in the MyBooks lists
I'm planning to fix them tonight. Here's the background if you're interested ... Since the intro of the scrollbar down the right-hand side of MyBooks there is now less horizontal room available for useful details (book title, author etc). It's usually worse for kepubs than epubs because of the longer |
This is not necessary anymore for sideloaded dictionaries. See #76 and pgaskin/dictutil#14 (comment).
Change replacement 'width' values so that original aspect ratio is maintained (#76 )
@jackiew1, are you ready for a release within the next hour or two? If I don't, I may not have time to do so until the weekend. I'll probably be making another within the next few weeks. |
I don't think I can update and test libnickel
|
Change replacement 'width' values so that original aspect ratio is maintained (#76)
I've finished looking at the dictionary changes: pgaskin/dictutil#14. I still need to test a few things with the dictzip v3 |
Slightly off topic, but related: NickelMenu, NickelSeries, and my other tools/mods will work fine with this firmware version. |
accommodate Kobo changes related to new dicts being released 2020-10-01 (#76)
@pgaskin Please will you add a note in your patch release post on MR that:
|
Released in v67 and MR:thread-333424. |
|
The text was updated successfully, but these errors were encountered: