This repository has been archived by the owner on Mar 8, 2024. It is now read-only.
fix: upgrade for 0.34 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JS IPFS v0.34 is coming out soon. It has breaking changes. This PR addresses those issues. I've tested this against v0.34.0-rc.1 in the [browser video streaming example](https://github.com/ipfs/js-ipfs/tree/master/examples/browser-video-streaming) and it all works. This PR also improves the code by actually streaming the file using `catReadableStream` over `cat` (which buffers content in memory). License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
49 tasks
|
ping @moshisushi - JS IPFS 0.34 is now out - it would be good to get this merged so it works with the latest version. |
|
Thanks, looks good! Nice getting rid of the lodash dep. :) Will get a new release out asap. |
|
Tested and works fine! 0.1.3 published to npm. Thanks again! |
alanshaw
pushed a commit
to ipfs/js-ipfs
that referenced
this pull request
Jan 18, 2019
pgc-13/hlsjs-ipfs-loader#7 was merged and released so this can now be fixed. License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw
pushed a commit
to ipfs/js-ipfs
that referenced
this pull request
Jan 21, 2019
pgc-13/hlsjs-ipfs-loader#7 was merged and released so this can now be fixed. License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw
pushed a commit
to ipfs/js-ipfs
that referenced
this pull request
Jan 21, 2019
pgc-13/hlsjs-ipfs-loader#7 was merged and released so this can now be fixed. License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
50 tasks
oliveriosousa
pushed a commit
to ipfs-examples/js-ipfs-examples
that referenced
this pull request
Jul 26, 2021
pgc-13/hlsjs-ipfs-loader#7 was merged and released so this can now be fixed. License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS IPFS v0.34 is coming out soon. It has breaking changes. This PR addresses those issues. I've tested this against v0.34.0-rc.1 in the browser video streaming example and it all works.
This PR also improves the code by actually streaming the file using
catReadableStreamovercat(which buffers content in memory).