Merge pull request #210 from zombodb/reduce-ub

chore: reduce UB in public API
pgcentralfoundation · Sep 23, 2021 · 4e21895 · 4e21895
2 parents 235e8ff + bf97110
commit 4e21895
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pgx/src/itemptr.rs b/pgx/src/itemptr.rs
@@ -103,11 +103,11 @@ pub fn u64_to_item_pointer_parts(value: u64) -> (pg_sys::BlockNumber, pg_sys::Of
 
 #[allow(clippy::not_unsafe_ptr_arg_deref)] // this is okay b/c we guard against ctid being null
 #[inline]
-pub fn item_pointer_is_valid(ctid: *const pg_sys::ItemPointerData) -> bool {
+pub unsafe fn item_pointer_is_valid(ctid: *const pg_sys::ItemPointerData) -> bool {
     if ctid.is_null() {
         false
     } else {
-        unsafe { *ctid }.ip_posid != pg_sys::InvalidOffsetNumber
+        (*ctid).ip_posid != pg_sys::InvalidOffsetNumber
     }
 }