-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pgrx init doesn't work with self-signed certificate #1430
Comments
If setting |
Thanks @workingjubilee . I do have |
…1448) ureq defines `default = ["tls", "gzip"]`, so "tls" feature (rustls) is currently always enabled even when native-tls is preferred, i.e. both rustls and native-tls is built if openssl headers are available and the user cannot opt-out from using rustls. This also disallows building cargo-pgrx on platforms not supported by the ring crate (dependency of rustls). This should also solve #1430 if `cargo-pgrx` is built with `--no-default-features --features native-tls`.
I first settled down to write up something using `rustls-native_certs` but then I actually noticed ureq simply enables this with a feature. This should fully solve #1430 for both rustls and native-tls.
With #1448 and #1449 this should be solved for either the rustls or native-tls builds of cargo-pgrx. @tumluliu Please test this using |
@workingjubilee sorry for the late reply and thanks a lot for the fix! We have tried |
…1448) ureq defines `default = ["tls", "gzip"]`, so "tls" feature (rustls) is currently always enabled even when native-tls is preferred, i.e. both rustls and native-tls is built if openssl headers are available and the user cannot opt-out from using rustls. This also disallows building cargo-pgrx on platforms not supported by the ring crate (dependency of rustls). This should also solve #1430 if `cargo-pgrx` is built with `--no-default-features --features native-tls`.
I first settled down to write up something using `rustls-native_certs` but then I actually noticed ureq simply enables this with a feature. This should fully solve #1430 for both rustls and native-tls.
Hi there, thanks for making this amazing framework. I however has hit the wall behind a coporation proxy as we are using our own certificate:
I took a very quick look at the code from
version.rs
here and it seems it caused by theureq
Agent
you created is using the defaultwebpki-roots
instead of the OS' trust store (refs: 1, 2 ). So I guess it's not very easy to change this behaviour without modifying themod.rs
codes? But I'm not sure since I'm neither an expert in security nor in rust. I'm wondering if there is a quick way to bypass this cert complaint when runninginit
. Could you provide some hints? Thanks again!p.s. my env: Ubuntu 22.04 Linux
The text was updated successfully, but these errors were encountered: