Update fcinfo fn toward actual usage #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function seems to have no callers, even in downstreams. Drop it.
A little consistency is a hobgoblin of etc. etc. It's important safety obligations appear where they are important, and not where they do not actually bind.
Now that we support pg12 as a baseline, it's a better public API.
Another case with no public users of it.
workingjubilee
commented
Nov 3, 2023
Comment on lines
-244
to
+247
| /// return unsafe { pg_return_void() }; | ||
| /// pg_return_void() | ||
| /// } | ||
| ///``` | ||
| /// | ||
| /// # Safety | ||
| /// | ||
| /// This function is unsafe for symmetry with the other related functions that deal with | ||
| /// `PG_FUNCTION_INFO_V1` functions. It has no specific safety invariants that must be met. | ||
| #[inline] | ||
| pub unsafe fn pg_return_void() -> pg_sys::Datum { | ||
| pub fn pg_return_void() -> pg_sys::Datum { |
There was a problem hiding this comment.
I should note, despite making this change, it's always better to be able to relax an unsafety than apply one, as it's (mostly) non-breaking to relax it.
thomcc
approved these changes
Nov 8, 2023
eeeebbbbrrrr
approved these changes
Nov 8, 2023
|
Go for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions that had no downstream users, some odd misdeclarations, and in one case a function we can expose finally as public because it's actually what we want people to be using, going forward (probably).