Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use composite_type! lifetimes in pgrx-sql-entity-graph #1463

Conversation

workingjubilee
Copy link
Member

I was working on fixing the auto-staticizing lifetime issues and noticed this likely would be landable on its own. This moves out struct CompositeTypeMacro into its own file and starts to actually modularize the code around it a little, to start actually preserving the lifetimes in their usage during macro expansion. Because we need to also generate wrapping types, it doesn't count as much of a cleanup on its own, but that's why I'm landing it separately.

@workingjubilee workingjubilee merged commit 7df371d into pgcentralfoundation:develop Jan 6, 2024
8 checks passed
@workingjubilee workingjubilee deleted the let-composite-types-live-in-graph branch January 6, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant