chore: perf optimize arg formatting #1519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Format args should almost never be passed as references to the `format!` because that causes some performance (boxing) degradation due to how Rust handles it internally (unable to optimize). In this PR I also removed a few trailing commas where they seemed to be incorrect.
|
Closing in favor of #1529, #1530, #1531, #1532 @workingjubilee should I delete that line or not? It is still present in one of these |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format args should almost never be passed as references to the
format!because that causes some performance (boxing) degradation due to how Rust handles it internally (unable to optimize).In this PR I also removed a few trailing commas where they seemed to be incorrect.
Lastly, in
pgrx-sql-entity-graph/src/pg_extern/mod.rsI removedto_string()as it seemed redundant (and also perf cost)