chore: inline non-core formatting args #1520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manually inlining format args to make the code more a bit more readable and shorter -- all these args are calling non-core formatting functions like logging, so extra care must be taken to check - just in case the macros were incorrectly implemented (e.g. if a macro has a special case for a literal string without params -- the way `panic!` was implemented in edition 2018)
| @@ -113,7 +113,7 @@ fn random_abort() { | |||
| pub unsafe extern "C" fn _PG_init() { | |||
| #[pg_guard] | |||
| extern "C" fn random_abort_callback(event: pg_sys::XactEvent, _arg: *mut std::os::raw::c_void) { | |||
| // info!("in global xact callback: event={}", event); | |||
| // info!("in global xact callback: event={event}"); | |||
There was a problem hiding this comment.
??? why is this line even here?
There was a problem hiding this comment.
someone was debugging something? i can delete it if you want
|
Closing in favor of #1529, #1530, #1531, #1532 @workingjubilee should I delete that line or not? It is still present in one of these |
|
It can go, yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually inlining format args to make the code more a bit more readable and shorter -- all these args are calling non-core formatting functions like logging, so extra care must be taken to check - just in case the macros were incorrectly implemented (e.g. if a macro has a special case for a literal string without params -- the way
panic!was implemented in edition 2018)