-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nullable type #1602
Nullable type #1602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, thoughts are incomplete and what is left over after sneezing my brains out all day. Wanted to post what I did have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be best to split things up so that we can land the Nullable type and the internal Array refactor and then work on extending the idea further in a followup.
Co-authored-by: Jubilee <46493976+workingjubilee@users.noreply.github.com>
As I mentioned while discussing this offsides, I have some other thoughts about the way the traits carve up the world that I think are better proposed as a refactoring since it's hard to really think them through in the review/talking format. |
Add an
Option
-like type to distinguish "This element is out-of-bounds" from "This element is a Postgresnull
", as well as genericizing over NullLayout types that mark where null elements are in a container (for example, the null bitslice on arrays).This is meant to implement the behavior requested in #620 and #1586
For iterators, a separate pull request has been split off: NotGyro#2