Redeclare additional *_walker fn

[daamien]

As a follow up to the discussion here
#1583 (comment)

Here's a patch to declare correctly the following functions:

• query_or_expression_tree_walker
• range_table_entry_walker
• planstate_tree_walker
• range_table_walker

This is a shameless copy of PR #1596 , I'm not entirely sure what I am actually doing here :)

Quick questions regarding the format:

• I see some arguments have the arg_ prefix while others don't... Like arg_node vs node in the query_tree_walker function... Is there a naming rule regarding this ?

• I'm unsure how to sort the functions... alphabetical order ?

[workingjubilee]

I see some arguments have the arg_ prefix while others don't... Like arg_node vs node in the query_tree_walker function... Is there a naming rule regarding this ?

We should generally copy the names from the C source except when they deviate from Rust convention. I'm not sure why raw_tree_expression_walker is like that, it's a deviation from that rule. Probably should be fixed.

I'm unsure how to sort the functions... alphabetical order ?

That will do fine for now.

[workingjubilee]

Would you be so kind as to make sure the arg names line up with the relevant _impl functions? (including in previously-added fn)

[daamien]

Would you be so kind as to make sure the arg names line up with the relevant _impl functions? (including in previously-added fn)

Sure !

Sorry I misunderstood your previous answer..... I will rename the arguments...

[workingjubilee]

I think all the ones you added here are correct?

stale