Fix lifetimes for IO functions #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workingjubilee
force-pushed
the
switch-json-io-funcs-to-use-serde-json-directly
branch
from
a323e6b to
a3325ff
Compare
|
This plus another small fix reduces the error output remaining for #1731 from 465 to 305 lines. |
workingjubilee
force-pushed
the
switch-json-io-funcs-to-use-serde-json-directly
branch
from
a3325ff to
df96586
Compare
|
235, actually. |
|
Another fix and now down to 199, and now I just need to rethink how I'm doing the ArgAbi impl for Vec. |
workingjubilee
deleted the
switch-json-io-funcs-to-use-serde-json-directly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While sorting out lifetime problems to make #1731 landable, I noticed JsonInOutFuncs is completely replaceable with two reexports. So I replaced it. This also made the changes to sort out the rest of the lifetimes obvious, and now we return CString always from these functions.