Test that pgrx can build after publishing #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will deal with the CI failures when I wake up. |
|
Just need to refactor rerunning the individual crate tests. |
|
We almost certainly are now doing redundant build/test cycling but that's fine because I'm going to work on cutting all that down LATER. |
This reverts commit 3bbf149.
|
finally. |
This reverts commit 3452844.
workingjubilee
changed the title
This was referenced Aug 11, 2024
workingjubilee
added a commit
that referenced
this pull request
Aug 14, 2024
One last essentially-administrative change, and part of the reason that I did all the mucking-about in #1796. We have a lot of code in pgrx-pg-sys's build.rs, and it's high time that we actually split out the real crate that it is. Currently this *just* moves that around, rather than doing any refactoring, to make the git blame trackable. The packaging test generates a sufficiently large cache that it cannot be done for every version of pgrx in the combinatoric fashion that we usually do, thus, we don't anymore! We simply run it for one version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that pgrx will always build after we publish it. It should never again take an excessive amount of time to release pgrx, because we will always be confident we are ready to release. This does not finish making the release "turnkey", but it does take care of every obstacle to such.
Note that there is a technicality: we are "only" testing that our package builds. We are not actually pulling a published-to-cargo release and testing it. We are not running the
cargo publish --dry-runcommand, either, because there is nocargo publish --workspace. Instead, we are packaging the workspace and rebuilding that package. This unfortunately demands that we factor out all the packages in the workspace that are not going to be published.Other details of the refactoring are informed by these oddities:
package.publish = falsedoesn't play well with the extensions tocargo package --workspace:-Zpackage-workspaceis not smart aboutpublish = falserust-lang/cargo#14356workspace.exclude = []does not properly support globs: cargo should support glob syntax on workspace excludes rust-lang/cargo#6009CARGO_TARGET_DIRfor building and testing our many examples or we run out of storage space on the runners.