Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions even if no specifier #1803

Conversation

workingjubilee
Copy link
Member

@workingjubilee workingjubilee commented Aug 13, 2024

Found a bug after doing some refactoring to improve how this tool works in general, making it more resilient to whatever the hell we do to our repo. This should allow us to have packages with different names than the paths to them, allowing arbitrary nesting and relocation, and also applies a less ad-hoc rule regarding "what packages are we updating".

Unblocks #1802.

Copy link
Contributor

@BradyBonnette BradyBonnette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve mostly because I was on a call with you while you were fixing it :D

@workingjubilee
Copy link
Member Author

That PR is now failing on another problem but hey! This one works as-intended.

@workingjubilee workingjubilee merged commit 1f7ce64 into pgcentralfoundation:develop Aug 13, 2024
13 checks passed
@workingjubilee workingjubilee deleted the update-versions-even-if-no-specifier branch August 14, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants