Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust helm chart to runAsNonRoot #2252

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

domi2120
Copy link
Contributor

Description

Currently the helm chart does not set a podSecurityContext. This may prevent the use in kubernetes clusters which do not allow images that run as root for security reasons.

The Container already uses a non root user, so setting runAsNonRoot and specifying the User/Group ID (because runAsNonRoot requires a numeric user for validation) is sufficient. This allows the use in kubernetes clusters which do not allow images running as root.

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • [x ] 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've written tests (if applicable) for all new methods and classes that I created. (rake test)
  • I've added documentation as necessary so users can easily use and understand this feature/fix.

@pglombardo
Copy link
Owner

Hi @domi2120 - thanks for the contribution/it makes sense.

cc: @mindovermiles262, @aduss-storable & @MindTooth who added & tested our initial helm chart support. I'll merge this soon unless I hear otherwise.

We need to merge #1589 too.

@pglombardo
Copy link
Owner

Thanks @domi2120 @MindTooth !

@pglombardo pglombardo merged commit 6eba585 into pglombardo:master Jun 14, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants