fix database service names in docker-compose-xx.yml #2821
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses issues in the
docker-compose-mysql.yml
anddocker-compose-mariadb.yml
files related to the naming of the database services. Currently, both the MySQL and MariaDB containers have inconsistent service names. The MySQL container is defined under the service namedb
, while the application container attempts to connect to it using the namemysql
. Similarly, the MariaDB container is also misconfigured. These discrepancies can lead to connection issues, particularly when the stack is integrated into a more complex environment, such as when the container is behind a reverse proxy. Using the correct service names is also a cleaner and more maintainable approach, regardless of the environment in which the stack is deployed.Type of Change
Checklist
rake test
)After making these changes, I ran the Docker Compose setup and verified that the application can now connect to both the MySQL and MariaDB databases without any issues.