Handle float/int slice problem and null values #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on findings outlined here: #14 (comment)
I think this will handle the case where we values which are mostly ints, but we get a float, or we have mostly floats but get an int (this is possible because firebase will change floats which are even to ints, for instance if you try to save
400.0
, firebase will save it as400
, and if all the other values in a collection are floats, we will have problems trying to append to the slice with the existing code.I expect adding a null into the mix will cause a similar crash, so in this case, I just detected a nil and added a 0 or 0.0 depending on the slice type.
I'm not entirely sure there isn't also a problem in the fireql library that this uses as well - will try out to verify asap.