feat: process table columns with GENERATED ALWAYS for partition_data_id() and partition_data_time() #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id() and partition_data_time() columns with GENERATED ALWAYS and can not ignored by param `p_ignored_columns`, eg. PK
keithf4
requested changes
Dec 30, 2024
| p_ignored_columns text[] DEFAULT NULL | ||
| ) RETURNS boolean AS $$ | ||
| DECLARE | ||
| identity_columns_count int; |
There was a problem hiding this comment.
Appreciate this PR and will definitely look at getting it merged in when possible. Would you mind using the conventions I have in the other functions for parameter (prefix with p_) and variable names (prefix with v_).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
columns with GENERATED ALWAYS and can not ignored by param
p_ignored_columns, eg. PKworkaround:
insert
OVERRIDING SYSTEM VALUEstring into the sql if there is column having defGENERATED ALWAYSexceptingp_ignored_columns.