-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bool mixed affinity support #88
Bool mixed affinity support #88
Conversation
@t-kataym please start review of this PR by pgspider team when You'll have enough time for this. If this PR is big for pgspider team work plan now, You can start review of small PRs when You'll have enough time. Small PRs see #89 or #89. It have got no conflicts with this PR. |
@mkgrgis Thank you for the PR. We will confirm it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkgrgis I completed my 1st review. Could you check these comment?
…s/sqlite_fdw into bool_mixed_affinity_support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I add some more comment for Warning fixing. Could you check that.
@t-kataym , could you please tell me about possible review date? |
I'm sorry for late response. |
Thanks, @t-kataym ! It's important to have approximate PR plan for me. I hope better by ISO:SQL datatype-affinity table implementation will be merged in 5 PRs before 2024 year. Such PRs as |
@mkgrgis I'm sorry for keeping you waiting. I finished my 1st review. Could you confirm my comments? |
Co-authored-by: LeAnhMinh <tsdv@localhost.localdomain>
@mkgrgis , Thank you for your fix. I finished the 2nd review and there are 2 comments. Could you fix them and rebase the code? |
Merge artefact
Yes, deleted, @nxhai98 . Please recheck. |
This PR include:
bool
support where some text caseinsensetive values treated as boolean values both inSELECT
andWHERE
. Mixed affinity values support borrowed from code lines about UUID.bool
support tests. No differences between versions noticed.uuid_extension.c
tosqlite_data_norm.c
with changing indent style to PostgreSQL. This file in future PRs will contain SQLite internal functions for mixed affinity cases:float
textInfinity
equal to SQLite9e999
, maybe timestamps etc.coalesce
during deparsing UUID normalization function.gcc
10.2+ warnings with PostgreSQL 16+.uuid
multi-versional tests and exclude to separate UUID test fromtype
test.bind
call context.text
affinity for PostgreSQLuuid
column because of SQLite C-language UUID normalization function always gets result withblob
affinity.text
during reading data for PostgreSQL column.There are no UUID functionality changes, only code refactoring.