Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0.0] Rename Acl\Resource to Acl\Component #13808

Closed
tempcke opened this issue Feb 7, 2019 · 1 comment
Closed

[4.0.0] Rename Acl\Resource to Acl\Component #13808

tempcke opened this issue Feb 7, 2019 · 1 comment
Assignees
@niden
Labels
breaks bc Functionality that breaks Backwards Compatibility enhancement Enhancement to the framework
Milestone
4.0.0

Comments

@tempcke
Copy link

tempcke commented Feb 7, 2019 •
edited by sergeyklay
Loading

As was determined here: #13791
Phalcon\Acl\Role should revert back to what it is in 3.4 and Phalcon\Acl\Resource should be renamed Phalcon\Acl\Component

This also relates to #13639

Phalcon\Acl\Resource -> Phalcon\Acl\Component
Phalcon\Acl\ResourceInterface -> Phalcon\Acl\ComponentInterface
Phalcon\Acl\ResourceAware -> Phalcon\Acl\ComponentAware

These should remain unchanged from 3.4:
Phalcon\Acl\Role
Phalcon\Acl\RoleInterface
Phalcon\Acl\RoleAware

Update change log as well as blog post
@tempcke tempcke mentioned this issue Feb 7, 2019
Closed
@sergeyklay sergeyklay added this to the 4.0.0 milestone Feb 7, 2019
@sergeyklay sergeyklay changed the title In Phalcon 4.0.0 Rename Acl\Resource to Acl\Component [4.0.0] Rename Acl\Resource to Acl\Component Feb 7, 2019
@niden niden added enhancement Enhancement to the framework breaks bc Functionality that breaks Backwards Compatibility labels Feb 8, 2019
@niden niden self-assigned this Feb 8, 2019
@niden niden mentioned this issue Feb 8, 2019
Merged
3 tasks
niden added a commit that referenced this issue Feb 8, 2019
@niden
[#13808] - Renaming ACL elements
d5ee9a5
niden added a commit that referenced this issue Feb 8, 2019
@niden
[#13808] - Adjusting tests
598c773
niden added a commit that referenced this issue Feb 8, 2019
@niden
[#13808] - Updating ext folder
d866e09
@niden
Copy link
Member

niden commented Feb 8, 2019

This has been addressed

@niden niden closed this as completed Feb 8, 2019
@niden niden added the 4.0 label Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niden niden

Labels
breaks bc Functionality that breaks Backwards Compatibility enhancement Enhancement to the framework
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
3 participants
@niden @sergeyklay @tempcke