Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFR]: Make testsuite PHPUnit 9 compatible #14837

Closed
ruudboon opened this issue Feb 11, 2020 · 2 comments
Closed

[NFR]: Make testsuite PHPUnit 9 compatible #14837

ruudboon opened this issue Feb 11, 2020 · 2 comments
Assignees
@niden
Labels
new feature request Planned Feature or New Feature Request

Comments

@ruudboon
Copy link
Member

Currently our test suite is failing under PHPUnit 9.
Looks like assertInternalType is deprecated. Our tests using this method should be refactored before upgrading.
@ruudboon ruudboon added the new feature request Planned Feature or New Feature Request label Feb 11, 2020
@ruudboon ruudboon mentioned this issue Feb 11, 2020
Merged
5 tasks
@niden
Copy link
Member

niden commented Apr 10, 2020

This will have to wait until fall, when PHP 7.2 is EOL.

@niden niden self-assigned this Apr 10, 2020
@niden niden added the 4.0.6 label Apr 10, 2020
@niden niden mentioned this issue Apr 11, 2020
Merged
5 tasks
niden added a commit that referenced this issue Apr 16, 2020
@niden
[#14837] - Updated changelog
e9813f0
niden added a commit that referenced this issue Apr 16, 2020
@niden
[#14837] - Removed assertInternalType and replaced it with assertTrue…
a44b2bb 
…/type
niden added a commit that referenced this issue Apr 16, 2020
@niden
[#14837] - PHPCS
df3b02f
@niden
Copy link
Member

niden commented Apr 16, 2020

Resolved

@niden niden closed this as completed Apr 16, 2020
@phalcon phalcon deleted a comment from dicamoises Apr 16, 2020
niden added a commit that referenced this issue May 16, 2020
@niden
[#14837] - Updated changelog
0292d68
niden added a commit that referenced this issue May 16, 2020
@niden
[#14837] - Removed assertInternalType and replaced it with assertTrue…
1d65f2c 
…/type
niden added a commit that referenced this issue May 16, 2020
@niden
[#14837] - PHPCS
e4088c8
@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niden niden

Labels
new feature request Planned Feature or New Feature Request
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niden @ruudboon