Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Wrong return type hint for Phalcon\Translate\InterpolatorFactory::newInstance #14996

Closed
sergeyklay opened this issue May 3, 2020 · 1 comment · Fixed by #14997
Closed

[BUG]: Wrong return type hint for Phalcon\Translate\InterpolatorFactory::newInstance #14996

sergeyklay opened this issue May 3, 2020 · 1 comment · Fixed by #14997
Assignees
@sergeyklay
Labels
bug A bug report status: low Low

Comments

@sergeyklay
Copy link
Contributor

Phalcon\Translate\InterpolatorFactory::newInstance has incorrect return type hint:

cphalcon/phalcon/Translate/InterpolatorFactory.zep

Lines 39 to 48 in 24857a7

public function newInstance(string! name) -> <AdapterInterface>
{
var definition;
this->checkService(name);
let definition = this->mapper[name];
return create_instance(definition);
}

But this method is meant to returns an Phalcon\Translate\Interpolator\InterpolatorInterface instance. This leads to a fatal error:

PHP Fatal error:
Return value of Phalcon\Translate\InterpolatorFactory::newInstance()
must implement interface Phalcon\Translate\Adapter\AdapterInterface,
instance of Phalcon\Translate\Interpolator\AssociativeArray returned in Unknown on line 0
@sergeyklay sergeyklay added bug A bug report status: unverified Unverified and removed status: unverified Unverified labels May 3, 2020
@sergeyklay sergeyklay self-assigned this May 3, 2020
@sergeyklay sergeyklay changed the title [BUG]: Wrong return type for Phalcon\Translate\InterpolatorFactory::newInstance [BUG]: Wrong return type hint for Phalcon\Translate\InterpolatorFactory::newInstance May 3, 2020
sergeyklay added a commit that referenced this issue May 3, 2020
@sergeyklay
Fixed return type hint for InterpolatorFactory::newInstance
d4a9990 
See: #14996
@sergeyklay sergeyklay mentioned this issue May 3, 2020
Merged
5 tasks
@sergeyklay sergeyklay linked a pull request May 3, 2020 that will close this issue
Fixed return type hint for InterpolatorFactory::newInstance #14997
Merged
5 tasks
@sergeyklay
Copy link
Contributor Author

Fixed in 4.0.x branch

niden pushed a commit that referenced this issue May 16, 2020
@sergeyklay @niden
Fixed return type hint for InterpolatorFactory::newInstance
3560a5e 
See: #14996
@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergeyklay sergeyklay

Labels
bug A bug report status: low Low
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed return type hint for InterpolatorFactory::newInstance phalcon/cphalcon
1 participant
@sergeyklay