Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFR] Allow view->partial to return instead of echo #2140

Closed
aleemb opened this issue Mar 7, 2014 · 3 comments
Closed

[NFR] Allow view->partial to return instead of echo #2140

aleemb opened this issue Mar 7, 2014 · 3 comments

Comments

@aleemb
Copy link

aleemb commented Mar 7, 2014

Currently I resort to ob_start() and ob_get_clean() but it's cumbersome. Would be nice to have a method getPartial() which returns the output as string instead of echo'ing it directly. I imagine quite a few designers would benefit from this. I have a genuine need myself so I can include my design components into smaller partials.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Verhaeg
Copy link

Verhaeg commented Mar 8, 2014

Hi there, idea really appreciated!
I'ld like the idea of partial always returning the contents instead of echoing.. one can easily add an echo before the partial and this will result in solving this issue as well.

maybe it is a bit hard to change this for 1.2.6 or 1.3.0 due to regression support, but at least having the possibility to return the contents instead would be very nice

phalcon pushed a commit that referenced this issue Mar 13, 2014
Fixed #2140 add param `autorender` to Phalcon\Mvc\View::partial
@mruz
Copy link
Contributor

mruz commented Jun 17, 2014

@dreamsxin why your changes aren't present? Could you add PR into 1.3.3?

@dreamsxin
Copy link
Contributor

@mruz May be a rollback, I resubmitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants