Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to check that response has not been already sent in phalcon/mvc/micro.zep #12668

Closed
wants to merge 9 commits into from
Closed

Need to check that response has not been already sent in phalcon/mvc/micro.zep #12668

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
74eee75
FIX Response Already Sent Error
Fabsolute Mar 1, 2017
cf02235
Update CHANGELOG.md
Fabsolute Mar 3, 2017
fd827d8
Merge branch '3.1.x' into 3.1.x
Fabsolute Mar 6, 2017
fa2bc1f
Test for Already Sent Error
Fabsolute Mar 10, 2017
1a22e10
FIX PSR
Fabsolute Mar 10, 2017
aeac58e
ADD Expect to Test
Fabsolute Mar 10, 2017
9d1cb2c
Update MicroTest.php
Fabsolute Mar 10, 2017
8d09df7
Update MicroTest.php
Fabsolute Mar 10, 2017
5d2f9cd
Update MicroTest.php
Fabsolute Mar 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- Added `prepend` parameter to `Phalcon\Loader::register` to specify autoloader's loading order to top most
- Fixed `Phalcon\Session\Bag::remove` to initialize the bag before removing a value [#12647](https://github.com/phalcon/cphalcon/pull/12647)
- Fixed `Phalcon\Mvc\Model::getChangedFields` to correct detect changes from NULL to Zero [#12628](https://github.com/phalcon/cphalcon/issues/12628)
- Fixed when `Micro::getReturnedValue()` is `string` or `ResponseInterface`, if response is handled in `Micro::after($handle)` or `Micro::finish($handle)`, `Phalcon` attemps to send response again, and faces `Response Already Sent` error.
- Fixed `Phalcon\Mvc\Model` to create/refresh snapshot after create/update/refresh operation [#11007](https://github.com/phalcon/cphalcon/issues/11007), [#11818](https://github.com/phalcon/cphalcon/issues/11818), [#11424](https://github.com/phalcon/cphalcon/issues/11424)

# [3.0.4](https://github.com/phalcon/cphalcon/releases/tag/v3.0.4) (2017-02-20)
Expand Down
10 changes: 7 additions & 3 deletions phalcon/mvc/micro.zep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,8 +985,10 @@ class Micro extends Injectable implements \ArrayAccess
*/
if typeof returnedValue == "string" {
let response = <ResponseInterface> dependencyInjector->getShared("response");
response->setContent(returnedValue);
response->send();
if !response->isSent() {
response->setContent(returnedValue);
response->send();
}
}

/**
Expand All @@ -997,7 +999,9 @@ class Micro extends Injectable implements \ArrayAccess
/**
* Automatically send the response
*/
returnedValue->send();
if !returnedValue->isSent() {
returnedValue->send();
}
}
}

Expand Down