-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.2.x Grouped Config #12884
3.2.x Grouped Config #12884
Conversation
Could you please update the CHANGELOG.md |
phalcon/config/adapter/grouped.zep
Outdated
* [ | ||
* [ | ||
* "filePath" => "path/to/config.php", | ||
* "adapter" => "php""path/to/config.dist.php" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"adapter" => "php""path/to/config.dist.php"
=> "adapter" => "php"
phalcon/config/adapter/grouped.zep
Outdated
//Set To Default Adapter If Passed As String | ||
if typeof configName === "string" { | ||
let configInstance = ["filePath" : configName, "adapter" : defaultAdapter]; | ||
} elseif !isset(configInstance["adapter"]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!isset(configInstance["adapter"])
=> !isset configInstance["adapter"]
phalcon/config/adapter/grouped.zep
Outdated
} | ||
|
||
if configInstance["adapter"] === "array" { | ||
if !isset(configInstance["config"]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same
* User: fenikkusu | ||
* Date: 6/6/17 | ||
* Time: 8:05 PM | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please remove this
c3c88ce
to
cf985f6
Compare
Changes Applied |
Thank you |
Hello!
In raising this pull request, I confirm the following (please check boxes):
Small description of change:
Many systems use the concept of distribution config files where config.conf is added to the repo but config.dist.conf is ignored. These changes allow us to easily accomplish the same concept in Phalcon. Additionally, this leverages the existing Config Factory to allow us to combine either a specifc adapter or multiple different adapters.
Thanks