Changes implementation of form's and element's getValue() and clear() methods #13500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses #13498
Fixed my earlier fix that fixed correct variables and left incorrect
Changes implementation of `Phalcon\Forms\Element::getValue()` and `Phalcon\Forms\Element::clear()` methods
scrnjakovic
changed the title
3 tasks
Properly returns value if form does not exist
Jurigag
reviewed
Sep 22, 2018
CHANGELOG-4.0.md
Outdated
| @@ -6,6 +6,8 @@ | |||
| - Added `Phalcon\Mvc\ModelInterface::getModelsMetaData` [#13070](https://github.com/phalcon/cphalcon/issues/13402) | |||
|
|
|||
| ## Changed | |||
| - `Phalcon\Forms\Form::clear` will no longer call `Phalcon\Forms\Element::clear`, instead it will clear/set default value itself, and `Phalcon\Forms\Element::clear` will now call `Phalcon\Forms\Form::clear` if it's assigned to the form, otherwise it will just clear itself. [#13500](https://github.com/phalcon/cphalcon/pull/13500) | |||
There was a problem hiding this comment.
Add it at the end of section instead of beginning
Jurigag
reviewed
Sep 22, 2018
phalcon/forms/form.zep
Outdated
| * If null, clear all | ||
| */ | ||
| if typeof elements == "array" { | ||
| if is_null(fields) { |
|
@Jurigag All fine now? |
niden
approved these changes
Oct 10, 2018
|
@scrnjakovic Thank you! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #13498
Small description of change:
Phalcon\Forms\Form::clear()method will no longer callPhalcon\Forms\Element::clear(), instead it will clear element's value itselfPhalcon\Forms\Element::clear()will now callPhalcon\Forms\Form::clear()passing its name or will clear itself if form does not existPhalcon\Forms\Element::getValue()will now callPhalcon\Forms\Form::getValue()or return its default value (instead of hardcodednull) if form does not existPhalcon\Forms\Form::getValue()will now try to get element's value from theTagor by calling element'sgetDefault()method before returningnullMore info: #13498