PR-11608 Modify redis backend #13563
Conversation
|
cc @sergeyklay |
| 'host' => env('TEST_RS_HOST', '127.0.0.1'), | ||
| 'port' => env('TEST_RS_PORT', 6379), | ||
| 'index' => env('TEST_RS_DB', 0), | ||
| 'statsKey' => '_PHCR', |
There was a problem hiding this comment.
Well, all these changes will now require the user to pass statsKey key more often, but previously not.
I think from the point of view of the Phalcon user this changelog entry "Made the specialKey (_PHCR) optional" is wrong because now he is forced to play with this key almost always (or at least more often)
There was a problem hiding this comment.
I disagree. The reason all these statsKey elements appear in the tests is because we assumed that the key would always be there. So all the existing tests must have that in the initialization of the Redis component.
For an real life application, this initialization would happen mostly in the DI container and there will be no more changes.
| @@ -413,7 +492,7 @@ public function queryKeysWithStatsKeyAndPrefix(UnitTester $I) | |||
| $keys = $cache->queryKeys(); | |||
| sort($keys); | |||
|
|
|||
| $I->assertEquals(['a', 'b'], $keys); | |||
| $I->assertEquals(['phalcon-a', 'phalcon-b'], $keys); | |||
There was a problem hiding this comment.
Is the business logic was changed? Previously we'd expect here result w/o prefix. Should we notice about this in the blogpost to alert users?
There was a problem hiding this comment.
No the business logic remains the same. The test was incorrect. The logic is:
$cache->get('a'); // 'a' (no statsKey, no prefix)
$cache->get('a'); // 'phalcon_a' (no statsKey, prefix "phalcon_")
$cache->get('a'); // '_PHCRphalcon_a' (statsKey "_PHCR", prefix "phalcon_")
…m/niden/cphalcon into feature/T11608-modify-redis-backend * 'feature/T11608-modify-redis-backend' of git://github.com/niden/cphalcon: [#13547] - Updated changelog [#13547] - Corrected name of the method and tests [#13547] - Changed getTitle and added renderTitle change: change log write error -Fixed `\Phalcon\Http\Response::setFileToSend` filename last much _ Refactored `Phalcon\Db\Adapter\Pdo::query` to use PDO's prepare and execute. `Phalcon\Db\Adapter::fetchAll` to use PDO's fetchAll style: PSR2 style error Added: `Phalcon\Acl\Adapter\Memory::addRole` support multiple inherited
…dy initialized/connected
|
@niden Could you please rebase |
* 4.0.x: [PR12189] - Removed unused variables; Corrected missing use statement [PR12189] - Corrected typo [PR12189] - Minor changes based on review [PR12189] - Modified header class and corrected tests [PR12189] - Corrected logic and test [PR12189] - Fixed tests [PR12189] - Added test for hasHeader [PR12189] - Updated changelog [PR12189] - Added hasHeader method Minor CI's config refactor and improvements
Hello!
In raising this pull request, I confirm the following (please check boxes):
Made the
specialKey(_PHCR) optional for thePhalcon\Cache\Backend\Redisadapter. This is based on the work of @pantaovayThanks