Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T10532 case insensitive column map #13569

Merged
merged 4 commits into from
Nov 4, 2018
Merged

T10532 case insensitive column map #13569

merged 4 commits into from
Nov 4, 2018

Conversation

niden
Copy link
Member

@niden niden commented Nov 2, 2018

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Work by @Skydev0h

Added a global ORM setting that allows to try to find a key in column map case-insensitively if it was not found by an exact match at first time. Can be a real fix for many Oracle bugs, because Phalcon does not expect that column names are converted to uppercase by Oracle in the query result.

Original PR: #11802

Thanks

@niden niden self-assigned this Nov 2, 2018
@niden niden requested a review from sergeyklay November 2, 2018 23:28
@niden
Copy link
Member Author

niden commented Nov 2, 2018

cc @sergeyklay

@sergeyklay
Copy link
Contributor

@niden Could you please rebase

* 4.0.x:
  [PR12189] - Removed unused variables; Corrected missing use statement
  [PR12189] - Corrected typo
  [PR12189] - Minor changes based on review
  [PR12189] - Modified header class and corrected tests
  [PR12189] - Corrected logic and test
  [PR12189] - Fixed tests
  [PR12189] - Added test for hasHeader
  [PR12189] - Updated changelog
  [PR12189] - Added hasHeader method
  Minor CI's config refactor and improvements
Copy link
Contributor

@sergeyklay sergeyklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niden niden merged commit 25dcfce into phalcon:4.0.x Nov 4, 2018
@niden niden deleted the T10532-case-insensitive-column-map branch December 7, 2018 01:02
@niden niden added the documentation Documentation required label Apr 9, 2019
@niden niden added 4.0 new feature request Planned Feature or New Feature Request and removed documentation Documentation required labels Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature request Planned Feature or New Feature Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants