T13680 breadcrumbs component #13682
Merged
T13680 breadcrumbs component #13682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @sergeyklay |
* upstream/4.0.x: Merge for #12547 Added some methods to Phalcon\Acl\Adapter\Memory [#12295] - Removed the final from the class definition [#12295] - Updated the changelog [#12295] - Added container tests [#12295] - Added Container object, PSR-11 compliant [#12295] - Added entry to the changelog [#12295] - Fixed interface [4.0.x] - Another correction to the test
* 4.0.x: Merge for #12547 Added some methods to Phalcon\Acl\Adapter\Memory [#12295] - Removed the final from the class definition [#12295] - Updated the changelog [#12295] - Added container tests [#12295] - Added Container object, PSR-11 compliant [#12295] - Added entry to the changelog [#12295] - Fixed interface [4.0.x] - Another correction to the test
CameronHall
suggested changes
Dec 24, 2018
phalcon/html/breadcrumbs.zep
Outdated
| * Clears the crumbx | ||
| * | ||
| * <code> | ||
| * $$breadcrumbs->clear() |
There was a problem hiding this comment.
Typo here with the extra $
phalcon/html/breadcrumbs.zep
Outdated
| /** | ||
| * Removes crumb by url. | ||
| * | ||
| * <core> |
There was a problem hiding this comment.
<core> should be <code>
sergeyklay
approved these changes
Dec 24, 2018
There was a problem hiding this comment.
There are some minor issues mentioned by @CameronHall, but on the whole LGTM
|
@sergeyklay Already addressed them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following (please check boxes):
Added `Html\Breadcrumbs component, offering an easy way to create breadcrumbs for your application
Thanks