Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all 'fresh' related code from the DI and DIInterface #13861

Merged
merged 2 commits into from
Feb 25, 2019
Merged

Remove all 'fresh' related code from the DI and DIInterface #13861

merged 2 commits into from
Feb 25, 2019

Conversation

dschissler
Copy link
Contributor

@dschissler dschissler commented Feb 24, 2019

Hello!

  • Type: code quality

  • Link to issue: This is a continuation of a larger effort to clean up the DI. This related to a few recently merged PRs:

  • PR 13846

  • PR 13854

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • This PR deletes a public function in the DI which is no longer used internally within Phalcon. Its possible that some third party code could rely on this in a plugin but I seriously doubt it. Hopefully this is just dead code YAY! After the Dispatcher is refactored according to the commented notes within that class then the creation of some new tests will need to be evaluated.

Through the PR mentioned in the top portion of this PR I have set the stage for this "was fresh" code to be removed. This also tightens up the DI interface. After I or someone else refactors the Dispatcher base class then its likely that some new clever tests will need to be created. For the moment this is just the next step in cleaning up the code quality and API.

@niden niden merged commit f3ecb25 into phalcon:4.0.x Feb 25, 2019
@niden
Copy link
Member

niden commented Feb 25, 2019

Thank you @dschissler

@niden niden added the enhancement Enhancement to the framework label Feb 25, 2019
@sergeyklay sergeyklay added the breaks bc Functionality that breaks Backwards Compatibility label Feb 25, 2019
@sergeyklay
Copy link
Contributor

@niden Interface has been changed. I added the Breaks BC label. Please mention this at the release log as well as documentation.

@dschissler

This comment was marked as abuse.

@dschissler dschissler deleted the di_removefresh branch March 1, 2019 04:25
@niden niden added the documentation Documentation required label Apr 9, 2019
@niden niden added 4.0 and removed documentation Documentation required labels Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks bc Functionality that breaks Backwards Compatibility enhancement Enhancement to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants