Refactored security tests from SecurityCest #13864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed get/set di test Removed DestroyTokenCest (covered by CheckTokenCest) Removed GetSessionTokenCest (covered by getRequestToken) Removed GetTokenCest (covered by GetTokenAndKeyCest) Removed GetTokenKeyCest (covered by GetTokenAndKeyCest) Removed GetWorkFactorCest (covered by GetSetWorkFactorCest) Removed GetDefaultHashCest (covered by GetSetDefaultHashCest) Removed SetRandomBytesCest (covered by GetSetRandomBytesCest)
Codecov Report
@@ Coverage Diff @@
## 4.0.x #13864 +/- ##
==========================================
+ Coverage 66.79% 66.81% +0.02%
==========================================
Files 448 448
Lines 89060 89060
==========================================
+ Hits 59487 59507 +20
+ Misses 29573 29553 -20
Continue to review full report at Codecov.
|
niden
approved these changes
Feb 25, 2019
|
Thank you @ruudboon |
niden
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored security tests.
Removed get/set di test
Removed DestroyTokenCest (covered by CheckTokenCest)
Removed GetSessionTokenCest (covered by getRequestToken)
Removed GetTokenCest (covered by GetTokenAndKeyCest)
Removed GetTokenKeyCest (covered by GetTokenAndKeyCest)
Removed GetWorkFactorCest (covered by GetSetWorkFactorCest)
Removed GetDefaultHashCest (covered by GetSetDefaultHashCest)
Removed SetRandomBytesCest (covered by GetSetRandomBytesCest)
See #13655