[Db] Generated DialectClass referring to a raw PHP class won't be found

[lubber-de]

Hello!

• Type: bug fix
• Link to issue: Oracle PDO: Class phalcon\db\dialect\oracle incubator#663

In raising this pull request, I confirm the following (please check boxes):

• I have read and understood the Contributing Guidelines?
• I have checked that another pull request for this purpose does not exist.
  Dialect Class outside of Zephir won't load because of missing CamelCase #12686 exists, but closed and messed up (indeed it was myself on another github account years ago)
• I wrote some tests for this PR.

Description

On Instantiating a Db-Instance, the DialectClass is generated by Zephir if not given as a property. The generated Class is always lowercase which does only work for internal zephir classes, but not for PHP-Classes for example the Oracle adapter given by the incubator.

This won't work...

... because the dialectClass Property is not given and phalcon tries to guess it on its own.
As zephir works case insensitive the generated class phalcon\db\dialect\oracle won't be found, because it's not inside Phalcon since 3.0, but available via incubator only

$test = new \Phalcon\Db\Adapter\Pdo\Oracle([
            'username'    => '',
            'password'    => '',
            'dbname'      => ''
        ]);

Result

Fatal error: Class 'phalcon\db\dialect\oracle' not found in ....

Workaround

If the dialectClass is given as property, then it works

$test = new \Phalcon\Db\Adapter\Pdo\Oracle([
            'username'    => '',
            'password'    => '',
            'dbname'      => '',
            'dialectClass' => \Phalcon\Db\Dialect\Oracle::class
        ]);

Closes

phalcon/incubator#663
More Info: phalcon/incubator#663 (comment)

[niden]

@sergeyklay 3.4?

[sergeyklay]

@niden It just looks good to me :) I can even merge it to 3.4.x branch, but it will be there for a long time.

[niden]

@sergeyklay the issue is not that it will go to 3.4 and stay there a long time, the issue is that we will need to release yet again one more v3 release....

I am fine if you want to merge this.

[lubber-de]

@niden FYI you probably have to release another 3.4 anyway, because I recently got lots of segfault crashes when using the incubator and instantiating oracle with php 7.3 and the latest 3.4.3 on windows .. But I am still testing what might triggering it or if it also affects other incubator components. I'll open another issue or even PR then.

[niden]

Thank you @lubber-de