Simplified events.

[SidRoberts]

Hello!

• Type: code quality

In raising this pull request, I confirm the following:

• I have read and understood the Contributing Guidelines
• I have checked that another pull request for this purpose does not exist
• [-] I wrote some tests for this PR
• I updated the CHANGELOG

Previously, the Events Manager was able to store events in two different systems - SplPriorityQueue and arrays. The system depended on whether priorities were enabled or not.

A lof of the code look similar to this:

if this->enablePriorities {
    // Handle SplPriorityQueue
} else {
    // Handle array
}

It doesn't make sense to duplicate the code functionality for two systems when just one can be used instead.

Now SplPriorityQueue is used regardless. If priorities are disabled, the default priority (new constant DEAULT_PRIORITY) is used instead so that everything has the same priority.

[codecov]

Codecov Report

Merging #13924 into 4.0.x will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #13924      +/-   ##
==========================================
+ Coverage   67.62%   67.63%   +0.01%     
==========================================
  Files         469      469              
  Lines       94394    94344      -50     
==========================================
- Hits        63831    63811      -20     
+ Misses      30563    30533      -30

Impacted Files	Coverage Δ
ext/phalcon/events/manager.zep.c	77.55% <0%> (+4.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03c89eb...3ce8a1b. Read the comment docs.

[niden]

Thank you @SidRoberts

[sergeyklay]

Thank you