Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed Paginator\Adapter::getPaginate() to paginate() #13973

Merged
merged 1 commit into from
Apr 14, 2019
Merged

Renamed Paginator\Adapter::getPaginate() to paginate() #13973

merged 1 commit into from
Apr 14, 2019

Conversation

SidRoberts
Copy link
Contributor

See 4f5381b

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • [-] I wrote some tests for this PR
  • [-] I updated the CHANGELOG

Small description of change:

Thanks

@codecov
Copy link

codecov bot commented Apr 14, 2019

Codecov Report

Merging #13973 into 4.0.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            4.0.x   #13973   +/-   ##
=======================================
  Coverage   67.87%   67.87%           
=======================================
  Files         469      469           
  Lines       94315    94315           
=======================================
  Hits        64014    64014           
  Misses      30301    30301

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b14982c...99adafc. Read the comment docs.

@sergeyklay sergeyklay added this to the 4.0.0 milestone Apr 14, 2019
@sergeyklay
Copy link
Contributor

@SidRoberts Should we update change log as well ?

@SidRoberts
Copy link
Contributor Author

@sergeyklay Update alpha.5 or alpha.1?

@sergeyklay
Copy link
Contributor

@SidRoberts alpha.5 please. Also feel free to mention version this change was actually made (even by mistake or wrongly).

@niden niden merged commit 65f34ee into phalcon:4.0.x Apr 14, 2019
@niden
Copy link
Member

niden commented Apr 14, 2019

Thank you @SidRoberts

@niden niden added breaks bc Functionality that breaks Backwards Compatibility enhancement Enhancement to the framework labels Apr 14, 2019
@SidRoberts SidRoberts deleted the paginator-getpaginate branch April 14, 2019 21:28
@niden niden added the documentation Documentation required label May 12, 2019
@niden niden added 4.0 and removed documentation Documentation required labels Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks bc Functionality that breaks Backwards Compatibility enhancement Enhancement to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants