Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T14095 view inconsistency #14098

Merged
merged 3 commits into from
May 20, 2019
Merged

T14095 view inconsistency #14098

merged 3 commits into from
May 20, 2019

Conversation

niden
Copy link
Member

@niden niden commented May 20, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Mvc\View::getRender() to call view->finish() instead of ob_end_clean()

Thanks

@niden niden added the enhancement Enhancement to the framework label May 20, 2019
@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #14098 into 4.0.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            4.0.x   #14098   +/-   ##
=======================================
  Coverage   71.56%   71.56%           
=======================================
  Files         488      488           
  Lines       95798    95798           
=======================================
  Hits        68555    68555           
  Misses      27243    27243

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ce3b08...ce94ceb. Read the comment docs.

@niden niden merged commit 92c12aa into phalcon:4.0.x May 20, 2019
@niden niden added the 4.0 label Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants