Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T13870 acl inherit order #14184

Merged
merged 5 commits into from
Jun 16, 2019
Merged

T13870 acl inherit order #14184

merged 5 commits into from
Jun 16, 2019

Conversation

niden
Copy link
Member

@niden niden commented Jun 16, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed various areas in Phalcon\Acl\Adapter and Phalcon\Acl\Adapter\Memory including comments, logic, denyComponentAccess and AdapterInterface.

Thanks

@niden niden added the documentation Documentation required label Jun 16, 2019
@niden
Copy link
Member Author

niden commented Jun 16, 2019

cc @sergeyklay

sergeyklay
sergeyklay previously approved these changes Jun 16, 2019
@codecov
Copy link

codecov bot commented Jun 16, 2019

Codecov Report

Merging #14184 into 4.0.x will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            4.0.x   #14184     +/-   ##
=========================================
+ Coverage   74.64%   74.75%   +0.1%     
=========================================
  Files         455      455             
  Lines       94441    94463     +22     
=========================================
+ Hits        70497    70615    +118     
+ Misses      23944    23848     -96
Impacted Files Coverage Δ
ext/phalcon/acl/adapter/memory.zep.c 92.52% <0%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99066eb...db6b1a9. Read the comment docs.

@niden niden merged commit b69fed7 into phalcon:4.0.x Jun 16, 2019
@niden niden deleted the T13870-acl-inherit-order branch September 12, 2019 21:46
@niden niden added the 4.0 label Dec 2, 2019
@niden niden removed the documentation Documentation required label Dec 15, 2019
@niden niden added bug A bug report status: low Low and removed Bug - Low labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: low Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants