Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Di remove 14396 #14397

Merged
merged 3 commits into from
Sep 22, 2019
Merged

Di remove 14396 #14397

merged 3 commits into from
Sep 22, 2019

Conversation

ruudboon
Copy link
Member

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed removing service in DI. It's a workaround while waiting for Zephir changes

@ruudboon ruudboon requested a review from niden September 21, 2019 18:22
@codecov
Copy link

codecov bot commented Sep 21, 2019

Codecov Report

Merging #14397 into 4.0.x will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.0.x   #14397      +/-   ##
==========================================
- Coverage   67.63%    67.5%   -0.13%     
==========================================
  Files         478      478              
  Lines      110961   110966       +5     
==========================================
- Hits        75053    74913     -140     
- Misses      35908    36053     +145

@ruudboon ruudboon requested a review from sergeyklay September 22, 2019 03:18
CHANGELOG-4.0.md Outdated Show resolved Hide resolved
@ruudboon ruudboon requested a review from sergeyklay September 22, 2019 08:06
@niden niden merged commit bd07cda into phalcon:4.0.x Sep 22, 2019
@niden niden added 4.0 labels Sep 22, 2019
@niden niden added bug A bug report status: low Low and removed Bug - Low labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: low Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants