Constructors should never declare return type [skip appveyor]

[sergeyklay]

Hello!

• Type: bug fix
• Link to issue: -

In raising this pull request, I confirm the following:

• I have read and understood the Contributing Guidelines
• I have checked that another pull request for this purpose does not exist
• I wrote some tests for this PR
• I have updated the relevant CHANGELOG
• I have created a PR for the documentation about this change

Small description of change: Constructors should never declare return type.
Thanks.

/cc @niden

[ruudboon]

Is this something Zephir specific? Looks like the default return type is void

https://www.php.net/manual/en/language.oop5.decon.php#object.construct

[sergeyklay]

Zephir != PHP. Did you see something related in the Zephir docs? PHP driven development in Zephir leads to unexpected results: https://travis-ci.org/phalcon/cphalcon/jobs/588067789

[ruudboon]

Zephir != PHP. Did you see something related in the Zephir docs? PHP driven development in Zephir leads to unexpected results: https://travis-ci.org/phalcon/cphalcon/jobs/588067789

Missed it btw in the docs of Zephir.

[sergeyklay]

@ruudboon Check any constructor here https://www.php.net/manual/en/book.spl.php

[codecov]

Codecov Report

Merging #14401 into 4.0.x will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            4.0.x   #14401   +/-   ##
=======================================
  Coverage   67.63%   67.63%           
=======================================
  Files         478      478           
  Lines      110961   110961           
=======================================
  Hits        75053    75053           
  Misses      35908    35908