Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T13518 isset private property #14659

Merged
merged 3 commits into from
Dec 25, 2019
Merged

T13518 isset private property #14659

merged 3 commits into from
Dec 25, 2019

Conversation

niden
Copy link
Member

@niden niden commented Dec 25, 2019

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Mvc\Model::__isset to take into account non visible properties by checking the getter if it exists
Fixed Phalcon\Mvc\Model::__set to return a more informative message if we are tying to access a non visible property

Thanks

@niden niden added 4.0.1 enhancement Enhancement to the framework status: low Low bug A bug report labels Dec 25, 2019
@codecov
Copy link

codecov bot commented Dec 25, 2019

Codecov Report

Merging #14659 into 4.1.x will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4.1.x   #14659      +/-   ##
==========================================
+ Coverage   67.47%   67.49%   +0.01%     
==========================================
  Files         483      483              
  Lines      111391   111403      +12     
==========================================
+ Hits        75166    75192      +26     
+ Misses      36225    36211      -14

@ruudboon
Copy link
Member

@niden I think we can sent this to 4.0.x branch

@niden
Copy link
Member Author

niden commented Dec 25, 2019

Merging here and cherry picking to 4.0.1

@niden niden merged commit 1314654 into phalcon:4.1.x Dec 25, 2019
@niden niden deleted the T13518-isset-private-property branch December 25, 2019 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report enhancement Enhancement to the framework status: low Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants