Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to create tables with NULL columns #14804

Merged
merged 9 commits into from
Feb 5, 2020
Merged

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Feb 3, 2020

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

It is not possible to create table with NULL columns.

Thanks

@Jeckerson Jeckerson self-assigned this Feb 3, 2020
@Jeckerson Jeckerson added 4.0.4 bug A bug report status: medium Medium labels Feb 4, 2020
@Jeckerson Jeckerson marked this pull request as ready for review February 4, 2020 12:07
ruudboon
ruudboon previously approved these changes Feb 4, 2020
@ruudboon
Copy link
Member

ruudboon commented Feb 4, 2020

@Jeckerson Travis failed but don't think it's caused by your changes. I restarted the build let's wait for that.

@Jeckerson Jeckerson changed the title Add else condition for isNotNull() check Add possibility to create tables with NULL columns Feb 4, 2020
@niden niden merged commit 04d9091 into 4.0.x Feb 5, 2020
@niden niden deleted the fix/add-null-column branch February 5, 2020 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: medium Medium
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants