Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T16019 volt double quotes #16024

Merged
merged 14 commits into from
Jul 19, 2022
Merged

T16019 volt double quotes #16024

merged 14 commits into from
Jul 19, 2022

Conversation

niden
Copy link
Member

@niden niden commented Jul 15, 2022

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Reverted to single quotes when volt code generates PHP code.
Any tag helpers only accept parameters with double quotes
Added more tests for all helpers
Renamed Phalcon\Tag::form() to Phalcon\Tag::formLegacy (helper form_legacy)

Thanks

@niden niden added the 5.0 The issues we want to solve in the 5.0 release label Jul 15, 2022
@niden niden requested a review from Jeckerson July 15, 2022 22:12
@niden niden self-assigned this Jul 15, 2022
@niden niden linked an issue Jul 15, 2022 that may be closed by this pull request
@niden niden merged commit 5169d46 into phalcon:5.0.x Jul 19, 2022
@niden niden deleted the T16019-volt-double-quotes branch July 19, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volt Replacing Single Quote with Double Quote
2 participants