Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T16451 dm select #16452

Merged
merged 4 commits into from
Oct 14, 2023
Merged

T16451 dm select #16452

merged 4 commits into from
Oct 14, 2023

Conversation

niden
Copy link
Member

@niden niden commented Oct 14, 2023

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Changed Phalcon\DataMapper\Query\Select::columns() to accept an array of columns (keys as aliases) instead of func_get_args

Thanks

@niden niden self-assigned this Oct 14, 2023
@niden niden requested a review from Jeckerson October 14, 2023 14:23
@niden niden added bug A bug report status: low Low 5.0 The issues we want to solve in the 5.0 release labels Oct 14, 2023
@niden niden changed the base branch from master to 5.0.x October 14, 2023 14:24
@niden niden merged commit 3e46944 into phalcon:5.0.x Oct 14, 2023
38 checks passed
@niden niden deleted the T16451-dm-select branch October 14, 2023 21:11
@niden niden mentioned this pull request Oct 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: low Low
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niden @Jeckerson