Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Workflow - Build Windows DLLs #16533

Merged
merged 15 commits into from
Feb 20, 2024
Merged

Conversation

JMoodyFWD
Copy link
Contributor

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:
I have created a new workflow that automatically builds the php_phalcon.dll files for use with all Windows PHP 8.x variants. The compiled extensions are appropriately named, bundled with License.txt and added as artifacts. The workflow has been tested and confirmed to be working.

Thanks to @niden for his base script as contribution for this fix as well as his guidance to help get this completed.

@niden niden added new feature request Planned Feature or New Feature Request 5.0 The issues we want to solve in the 5.0 release enhancement Enhancement to the framework and removed new feature request Planned Feature or New Feature Request labels Feb 20, 2024
@niden niden merged commit 56e46a5 into phalcon:5.0.x Feb 20, 2024
50 checks passed
@niden
Copy link
Member

niden commented Feb 20, 2024

Thank you @JMoodyFWD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release enhancement Enhancement to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants