Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to php8.0 #11

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

rayanlevert
Copy link
Contributor

@rayanlevert rayanlevert commented Feb 16, 2024

Hello !

I managed to see a little problem with the adapter Slack, the cURL resource in php8.0+ was never closed because of the instance 'CurlHandle' implemented in these versions, instead of resource type.

So I upgraded the whole package to php8.0+, like the last version of Phalcon which requires php8.0+ :)

Modified

  • Used php8.0 constructor property promotion
  • Phalcon\Incubator\Logger\Adapter\Slack uses the CurlHandle instance instead of resource type
  • Phalcon\Incubator\Logger\Adapter\Udp uses the Socket instance instead of resource type

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Merging #11 (fe8e3f1) into master (67cab77) will increase coverage by 0.21%.
The diff coverage is 57.14%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #11      +/-   ##
============================================
+ Coverage     25.71%   25.92%   +0.21%     
- Complexity       42       44       +2     
============================================
  Files             4        4              
  Lines           140      135       -5     
============================================
- Hits             36       35       -1     
+ Misses          104      100       -4     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant