Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review tests #1488

Merged
merged 2 commits into from
Mar 14, 2021
Merged

Review tests #1488

merged 2 commits into from
Mar 14, 2021

Conversation

Jeckerson
Copy link
Member

Hello!

  • Type: code quality
  • Link to issue:

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR

Small description of change:

Thanks

@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #1488 (56c27d9) into 4.0.x (e65d38c) will decrease coverage by 0.01%.
The diff coverage is 4.25%.

@@           Coverage Diff            @@
##           4.0.x   #1488      +/-   ##
========================================
- Coverage   3.16%   3.15%   -0.02%     
========================================
  Files        111     111              
  Lines       5112    5111       -1     
========================================
- Hits         162     161       -1     
  Misses      4950    4950              

Copy link
Contributor

@BeMySlaveDarlin BeMySlaveDarlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good for me

@Jeckerson Jeckerson added this to the 4.0.x milestone Mar 14, 2021
@Jeckerson Jeckerson merged commit 94d96c9 into 4.0.x Mar 14, 2021
@Jeckerson Jeckerson deleted the review-tests branch March 14, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants